Bit integration docker #23
Conversation
replace db uri add Flask-Cors to requirements.txt linting with black formatter remove fetch env variables duplication change pull-push branch for github action to bit branch add postgresql test db add shell_context_processor Add -h postgres to psql command Place PGPASSWORD at the start of psql command Add env for running test * Update main.yml (Patch anitab-org#21) Co-authored-by: Aditya Kurkure use non-macOS syntax for db_uri and add db envs Add postgres db url for github action Add test for db_test_uri remove hard coded test db uri Add psycopg2 Fix db type to postgres+psycopg2 add env to Generate coverage report move env to global runner focus pytest cov on tests folder Remove print command
|
Oops I accidently added another commit as well. I'll rebase the changes. |
epicadk
force-pushed
the
bit-integration-docker
branch
from
53aefc2 to
d897e73
Compare
mtreacy002
force-pushed
the
initial-bit-integration
branch
from
21a3956 to
163502a
Compare
| migrate = Migrate(app, db) | ||
|
|
||
| cors.init_app(app, resources={r"*": {"origins": "http:BIT:5000"}}) |
There was a problem hiding this comment.
can we use 2 origins? one from docker (this one) and the other one is the localhost:5000 if we run the app locally
There was a problem hiding this comment.
can we use 2 origins? one from docker (this one) and the other one is the localhost:5000 if we run the app locally
Yup I'll add them
| if __name__ == "__main__": | ||
| # if we use docker then we can also run it on the default 5000 port |
There was a problem hiding this comment.
can we keep both. So, give options for people who want to run locally as well using port 4000. we can comment that option out when it's not being used.
| @@ -3,4 +3,12 @@ COPY ./requirements.txt /dockerBuild/requirements.txt | |||
| WORKDIR /dockerBuild | |||
| RUN pip install --no-cache-dir -r requirements.txt | |||
| COPY . /dockerBuild | |||
| ENV DB_TYPE=postgresql | |||
There was a problem hiding this comment.
Don't we need to use the same docker env for db postgres that being used in BIT backend?
Bcoz that's how the 2 backends connect to the postgres locally.
There was a problem hiding this comment.
Yes it is the same host. Let me see where the POSTGRES_HOST and the POSTGRES_PORT and being used and i'll get back to you , but what I can tell you is that they are connected to the same postgre database.
mtreacy002
force-pushed
the
initial-bit-integration
branch
3 times, most recently
from
3ab6260 to
928bbe5
Compare
Description
Added docker files to make setup easier.
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only